[WPB-28089] Treat team collaborators like team members in contact search (second attempt). - #5488
Open
fisx wants to merge 17 commits into
Conversation
fisx
force-pushed
the
WPB-28089-treat-team-collaborators-like-team-members-in-contact-search-_second-attempt_
branch
from
August 27, 2026 13:41
fa423be to
b228fdb
Compare
zebot
added
the
ok-to-test
Was previously UserSubsystem, but since it TeamCollaboratorsSubsystem is also used outside of Brig, that is not always available. Further changes: - Support BrigAPIAccess locally in Brig. - Change collaborator field type in UserDoc to collapse `Nothing` and `Just []` (remove the Maybe).
(I don't understand what it is about, and there is no author to ask.)
(This end-point only updates searchability settings, nothing else.)
This is only where we don't expect to use it. if we're wrong about this, a warning will be logged.
fisx
force-pushed
the
WPB-28089-treat-team-collaborators-like-team-members-in-contact-search-_second-attempt_
branch
from
August 28, 2026 10:35
33bbc46 to
0bfdbe6
Compare
fisx
marked this pull request as ready for review
August 28, 2026 11:04
blackheaven
requested changes
Aug 28, 2026
|
|
||
| -- | The 'Endpoint' is brig's own; it is only used for the operations that have | ||
| -- no local implementation yet. | ||
| interpretBrigAPIAccessLocally :: |
Contributor
There was a problem hiding this comment.
You still need to convince Akshay
Contributor
Author
There was a problem hiding this comment.
Co-authored-by: Gautier DI FOLCO <gautier.difolco@wire.com>
…cess.hs Co-authored-by: Gautier DI FOLCO <gautier.difolco@wire.com>
blackheaven
approved these changes
Aug 28, 2026
Contributor
|
Seen with @fisx we cannot simply use |
…m-collaborators-like-team-members-in-contact-search-_second-attempt_' into WPB-28089-treat-team-collaborators-like-team-members-in-contact-search-_second-attempt_
This has been added in baf4fbc; after it had been touched several times since its birth: the old bytestring didn't fit what ES did any more. I can't think of a way in which this comment may be helpful, so I've removed it.
... in a long list of "not implemented" errors. Without this interpreter or something analogous, some tests in Wire.TeamCollaboratorsSubsystem.InterpreterSpec will fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-28089
obsoletes #5452
Checklist
Revisit design choices around BrigAPIAccess.Local (separate PR)changelog.d